Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(contour_array): add layer param, test disu contours and export #1975

Merged
merged 1 commit into from
Oct 18, 2023

Conversation

wpbonelli
Copy link
Member

@wpbonelli wpbonelli commented Oct 3, 2023

  • refactor some disu test grids/models into fixtures
  • update PlotMapView.contour_array() docstring
  • add layer param to flopy.export.utils.contour_array()
  • pop/pass layer kwarg to contour_array() in export_array_contours()
  • test export_array_contours() disu grids with constant and variable ncpl
  • test PlotMapView.contour_array() various array dimensions, with/without layer
  • motivated by does flopy.export.utils.export_array_contours() work for disu? #1953

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Merging #1975 (2a7aa0e) into develop (3e176d0) will decrease coverage by 0.1%.
The diff coverage is 57.1%.

@@            Coverage Diff            @@
##           develop   #1975     +/-   ##
=========================================
- Coverage     72.7%   72.7%   -0.1%     
=========================================
  Files          258     258             
  Lines        57452   58830   +1378     
=========================================
+ Hits         41792   42790    +998     
- Misses       15660   16040    +380     
Files Coverage Δ
flopy/export/utils.py 66.4% <100.0%> (+<0.1%) ⬆️
flopy/plot/map.py 84.0% <ø> (ø)
flopy/discretization/structuredgrid.py 46.9% <0.0%> (ø)
flopy/discretization/vertexgrid.py 82.5% <0.0%> (ø)

... and 72 files with indirect coverage changes

@wpbonelli wpbonelli marked this pull request as ready for review October 3, 2023 20:42
@wpbonelli wpbonelli changed the title test(contours): test disu contours and export refactor(contour_array): add layer param, test disu contours and export Oct 6, 2023
@wpbonelli wpbonelli marked this pull request as draft October 6, 2023 19:24
…ests

* add layer param to flopy.export.utils.contour_array()
* pop/pass layer kwarg to contour_array() in export_array_contours()
* test export_array_contours() disu grids with constant/variable ncpl
* test PlotMapView.contour_array() array formats and with/without layer
* update PlotMapView.contour_array() docstring (dimension expectations)
* refactor some disu test grids & models into fixtures
@wpbonelli wpbonelli marked this pull request as ready for review October 18, 2023 13:54
@wpbonelli wpbonelli merged commit 4ed68a2 into modflowpy:develop Oct 18, 2023
21 checks passed
@wpbonelli wpbonelli deleted the test-disu-contours branch October 18, 2023 20:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants